[ 
https://issues.apache.org/jira/browse/NIFI-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15676854#comment-15676854
 ] 

ASF GitHub Bot commented on NIFI-2954:
--------------------------------------

Github user olegz commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1244#discussion_r88666833
  
    --- Diff: 
nifi-nar-bundles/nifi-avro-bundle/nifi-avro-processors/src/main/java/org/apache/nifi/processors/avro/ExtractAvroMetadata.java
 ---
    @@ -54,7 +54,7 @@
     import org.apache.nifi.processor.Relationship;
     import org.apache.nifi.processor.exception.ProcessException;
     import org.apache.nifi.processor.io.InputStreamCallback;
    -import org.apache.nifi.processor.util.StandardValidators;
    +import org.apache.nifi.util.validator.StandardValidators;
    --- End diff --
    
    Wouldn't this break all the existing processors that are not part of NiFi 
distribution? Basically any custom/in-house developed processor?


> Bouncycastle dependencies are duplicated throughout NARs
> --------------------------------------------------------
>
>                 Key: NIFI-2954
>                 URL: https://issues.apache.org/jira/browse/NIFI-2954
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Tools and Build
>    Affects Versions: 1.0.0
>            Reporter: Aldrin Piri
>            Assignee: Joseph Witt
>             Fix For: 1.1.0
>
>
> I was working with some of the NiFi dependencies for incorporation with/use 
> by MiNiFi and saw that several libraries were duplicated throughout all NARs.
> Of note were the bouncycastle dependencies which, together, are ~4MB in size.
> {code}
> # apiri @ computer in /usr/local/opt/nifi/libexec [17:20:23]
> $ find {lib,work} -type f -name '*bcprov-jdk15on*' | wc -l
>       54
> # apiri @ computer in /usr/local/opt/nifi/libexec [17:20:28]
> $ find {lib,work} -type f -name '*bcpkix*' | wc -l
>       53
> # apiri @ computer in /usr/local/opt/nifi/libexec [17:20:33]
> $ ls -lash 
> work/nar/framework/nifi-framework-nar-1.0.0.nar-unpacked/META-INF/bundled-dependencies/bcprov-jdk15on-1.54.jar
> 3.2M -rw-r--r-- 1 apiri admin 3.2M Oct  4 12:24 
> work/nar/framework/nifi-framework-nar-1.0.0.nar-unpacked/META-INF/bundled-dependencies/bcprov-jdk15on-1.54.jar
> # apiri @ computer in /usr/local/opt/nifi/libexec [17:20:39]
> $ ls -lash 
> work/nar/framework/nifi-framework-nar-1.0.0.nar-unpacked/META-INF/bundled-dependencies/bcpkix-jdk15on-1.54.jar
> 660K -rw-r--r-- 1 apiri admin 658K Oct  4 12:24 
> work/nar/framework/nifi-framework-nar-1.0.0.nar-unpacked/META-INF/bundled-dependencies/bcpkix-jdk15on-1.54.jar
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to