[
https://issues.apache.org/jira/browse/NIFI-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15677464#comment-15677464
]
Mark Payne commented on NIFI-2954:
----------------------------------
@joewitt I agree. I am not a fan of having to move the classes around like
this, but we should consider the following key points here:
* Old NAR's that were previously built should still work without a problem.
* In order for a third-party NAR to use the 1.1.0 dependencies, they are
already required to update their pom.xml (or equivalent) to point to a new
artifact. We are simply changing which artifact that they should point at.
* I'd like to avoid changing any package names but I understand why that was
done. I'm a +0 there.
We definitely do need to get rid of those extra bouncy castle jars, though.
Kind of a rock & a hard place. But I think the pro's do outweigh the con's in
this case, and I think we are operating within the scope of the Versioning
Guide that we have, provided that the Migration Guidance has a blurb supplied
that details exactly what must be done to depend on the validators.
Overall I'm a +1.
> Bouncycastle dependencies are duplicated throughout NARs
> --------------------------------------------------------
>
> Key: NIFI-2954
> URL: https://issues.apache.org/jira/browse/NIFI-2954
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Tools and Build
> Affects Versions: 1.0.0
> Reporter: Aldrin Piri
> Assignee: Joseph Witt
> Priority: Blocker
> Fix For: 1.1.0
>
>
> I was working with some of the NiFi dependencies for incorporation with/use
> by MiNiFi and saw that several libraries were duplicated throughout all NARs.
> Of note were the bouncycastle dependencies which, together, are ~4MB in size.
> {code}
> # apiri @ computer in /usr/local/opt/nifi/libexec [17:20:23]
> $ find {lib,work} -type f -name '*bcprov-jdk15on*' | wc -l
> 54
> # apiri @ computer in /usr/local/opt/nifi/libexec [17:20:28]
> $ find {lib,work} -type f -name '*bcpkix*' | wc -l
> 53
> # apiri @ computer in /usr/local/opt/nifi/libexec [17:20:33]
> $ ls -lash
> work/nar/framework/nifi-framework-nar-1.0.0.nar-unpacked/META-INF/bundled-dependencies/bcprov-jdk15on-1.54.jar
> 3.2M -rw-r--r-- 1 apiri admin 3.2M Oct 4 12:24
> work/nar/framework/nifi-framework-nar-1.0.0.nar-unpacked/META-INF/bundled-dependencies/bcprov-jdk15on-1.54.jar
> # apiri @ computer in /usr/local/opt/nifi/libexec [17:20:39]
> $ ls -lash
> work/nar/framework/nifi-framework-nar-1.0.0.nar-unpacked/META-INF/bundled-dependencies/bcpkix-jdk15on-1.54.jar
> 660K -rw-r--r-- 1 apiri admin 658K Oct 4 12:24
> work/nar/framework/nifi-framework-nar-1.0.0.nar-unpacked/META-INF/bundled-dependencies/bcpkix-jdk15on-1.54.jar
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
