lordgamez commented on code in PR #1490:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1490#discussion_r1098413827
##########
extensions/rocksdb-repos/database/OpenRocksDb.cpp:
##########
@@ -118,8 +114,18 @@ rocksdb::DB* OpenRocksDb::get() {
return impl_.get();
}
-} // namespace internal
-} // namespace minifi
-} // namespace nifi
-} // namespace apache
-} // namespace org
+std::optional<uint64_t> OpenRocksDb::getApproximateSizes() const {
+ rocksdb::SizeApproximationOptions options;
+ options.include_memtabtles = true;
+ std::array<rocksdb::Range, 1> ranges;
+ ranges[0].start = "";
+ ranges[0].limit = "~";
+ uint64_t value = 0;
+ auto status = impl_->GetApproximateSizes(options, column_->handle.get(),
ranges.data(), 1, &value);
Review Comment:
Updated in 38e9c97ff6fbcfb6479eec3615c025d076d1274b. Yes
`include_memtabtles` us a typo in the rocksdb API :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
