fgerlits commented on code in PR #1509:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1509#discussion_r1106870043
##########
extensions/rocksdb-repos/FlowFileRepository.h:
##########
@@ -66,16 +66,14 @@ class FlowFileRepository : public ThreadedRepository,
public SwapManager {
}
explicit FlowFileRepository(const std::string& repo_name = "",
- std::filesystem::path checkpoint_dir =
FLOWFILE_CHECKPOINT_DIRECTORY,
+ std::filesystem::path /*checkpoint_dir*/ =
FLOWFILE_CHECKPOINT_DIRECTORY,
Review Comment:
could this parameter be removed? as far as I can see, this constructor is
only used in a few unit tests (and from the other constructor, but that
wouldn't need to be changed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
