adamdebreceni commented on code in PR #1509:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1509#discussion_r1106933132
##########
extensions/rocksdb-repos/FlowFileRepository.cpp:
##########
@@ -126,38 +123,28 @@ void FlowFileRepository::run() {
flush();
}
-void FlowFileRepository::prune_stored_flowfiles() {
- const auto encrypted_env =
createEncryptingEnv(utils::crypto::EncryptionManager{config_->getHome()},
DbEncryptionOptions{checkpoint_dir_.string(), ENCRYPTION_KEY_NAME});
- logger_->log_info("Using %s FlowFileRepository checkpoint", encrypted_env ?
"encrypted" : "plaintext");
-
- auto set_db_opts = [encrypted_env]
(minifi::internal::Writable<rocksdb::DBOptions>& db_opts) {
- db_opts.set(&rocksdb::DBOptions::create_if_missing, true);
- db_opts.set(&rocksdb::DBOptions::use_direct_io_for_flush_and_compaction,
true);
- db_opts.set(&rocksdb::DBOptions::use_direct_reads, true);
- if (encrypted_env) {
- db_opts.set(&rocksdb::DBOptions::env, encrypted_env.get(),
EncryptionEq{});
- } else {
- db_opts.set(&rocksdb::DBOptions::env, rocksdb::Env::Default());
- }
- };
- auto checkpointDB = minifi::internal::RocksDatabase::create(set_db_opts, {},
checkpoint_dir_.string(), minifi::internal::RocksDbMode::ReadOnly);
- std::optional<minifi::internal::OpenRocksDb> opendb;
- if (nullptr != checkpoint_) {
- opendb = checkpointDB->open();
- if (opendb) {
- logger_->log_trace("Successfully opened checkpoint database at '%s'",
checkpoint_dir_.string());
- } else {
- logger_->log_error("Couldn't open checkpoint database at '%s' using live
database", checkpoint_dir_.string());
- opendb = db_->open();
- }
- if (!opendb) {
- logger_->log_trace("Could not open neither the checkpoint nor the live
database.");
- return;
+bool FlowFileRepository::ExecuteWithRetry(const
std::function<rocksdb::Status()>& operation) {
+ std::chrono::milliseconds waitTime = 0ms;
+ for (int i=0; i < 3; ++i) {
Review Comment:
added constant
##########
extensions/rocksdb-repos/FlowFileRepository.cpp:
##########
@@ -126,38 +123,28 @@ void FlowFileRepository::run() {
flush();
}
-void FlowFileRepository::prune_stored_flowfiles() {
- const auto encrypted_env =
createEncryptingEnv(utils::crypto::EncryptionManager{config_->getHome()},
DbEncryptionOptions{checkpoint_dir_.string(), ENCRYPTION_KEY_NAME});
- logger_->log_info("Using %s FlowFileRepository checkpoint", encrypted_env ?
"encrypted" : "plaintext");
-
- auto set_db_opts = [encrypted_env]
(minifi::internal::Writable<rocksdb::DBOptions>& db_opts) {
- db_opts.set(&rocksdb::DBOptions::create_if_missing, true);
- db_opts.set(&rocksdb::DBOptions::use_direct_io_for_flush_and_compaction,
true);
- db_opts.set(&rocksdb::DBOptions::use_direct_reads, true);
- if (encrypted_env) {
- db_opts.set(&rocksdb::DBOptions::env, encrypted_env.get(),
EncryptionEq{});
- } else {
- db_opts.set(&rocksdb::DBOptions::env, rocksdb::Env::Default());
- }
- };
- auto checkpointDB = minifi::internal::RocksDatabase::create(set_db_opts, {},
checkpoint_dir_.string(), minifi::internal::RocksDbMode::ReadOnly);
- std::optional<minifi::internal::OpenRocksDb> opendb;
- if (nullptr != checkpoint_) {
- opendb = checkpointDB->open();
- if (opendb) {
- logger_->log_trace("Successfully opened checkpoint database at '%s'",
checkpoint_dir_.string());
- } else {
- logger_->log_error("Couldn't open checkpoint database at '%s' using live
database", checkpoint_dir_.string());
- opendb = db_->open();
- }
- if (!opendb) {
- logger_->log_trace("Could not open neither the checkpoint nor the live
database.");
- return;
+bool FlowFileRepository::ExecuteWithRetry(const
std::function<rocksdb::Status()>& operation) {
+ std::chrono::milliseconds waitTime = 0ms;
Review Comment:
renamed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
