szaszm commented on code in PR #1504:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1504#discussion_r1108552010
##########
PROCESSORS.md:
##########
@@ -20,10 +20,11 @@
- [DeleteAzureDataLakeStorage](#deleteazuredatalakestorage)
- [DeleteGCSObject](#deletegcsobject)
- [DeleteS3Object](#deletes3object)
+- [ExecuteLuaScript](#executeluascript)
- [ExecuteProcess](#executeprocess)
- [ExecutePythonProcessor](#executepythonprocessor)
+- [ExecutePythonScript](#executepythonscript)
- [ExecuteSQL](#executesql)
-- [ExecuteScript](#executescript)
- [ExtractText](#extracttext)
Review Comment:
We should go back to a single processor in the docs as well.
##########
bootstrap.sh:
##########
@@ -263,9 +263,8 @@ add_option HTTP_CURL_ENABLED ${TRUE} "DISABLE_CURL"
add_option LIBARCHIVE_ENABLED ${TRUE} "DISABLE_LIBARCHIVE"
add_dependency LIBARCHIVE_ENABLED "libarchive"
-add_option EXECUTE_SCRIPT_ENABLED ${FALSE} "ENABLE_SCRIPTING"
-add_dependency EXECUTE_SCRIPT_ENABLED "python"
-add_dependency EXECUTE_SCRIPT_ENABLED "lua"
+add_option PYTHON_SCRIPTING_ENABLED ${FALSE} "ENABLE_PYTHON_SCRIPTING"
+add_option LUA_SCRIPTING_ENABLED ${FALSE} "ENABLE_LUA_SCRIPTING"
Review Comment:
I imagined the ExecuteScript + script executors architecture with 3
extensions:
- scripting: ExecuteScript without any executors
- python: PythonScriptExecutor and support for python processors
- lua: LuaScriptExecutor and lua processors
How does it work now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
