martinzink commented on code in PR #1501: URL: https://github.com/apache/nifi-minifi-cpp/pull/1501#discussion_r1108533223
########## libminifi/include/Connection.h: ########## @@ -58,8 +58,8 @@ class Connection : public core::Connectable { Connection(const Connection &parent) = delete; Connection &operator=(const Connection &parent) = delete; - static constexpr uint64_t DEFAULT_BACKPRESSURE_SIZE_THRESHOLD = 10000; - static constexpr uint64_t DEFAULT_BACKPRESSURE_DATA_THRESHOLD = 10_MB; + static constexpr uint64_t DEFAULT_BACKPRESSURE_THRESHOLD_COUNT = 10000; + static constexpr uint64_t DEFAULT_BACKPRESSURE_THRESHOLD_DATA_SIZE = 10_MB; Review Comment: based on our conversation I've modified it to 2000 / 100MB in https://github.com/apache/nifi-minifi-cpp/pull/1501/commits/75e3d93ddd845f30c8674ca03b4f62b2bf0faf97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org