tpalfy commented on code in PR #6769:
URL: https://github.com/apache/nifi/pull/6769#discussion_r1113406776
##########
nifi-nar-bundles/nifi-asn1-bundle/nifi-asn1-services/src/main/java/org/apache/nifi/jasn1/JASN1Reader.java:
##########
@@ -134,17 +135,32 @@ public class JASN1Reader extends
AbstractConfigurableComponent implements Record
.required(false)
.build();
+ private static final PropertyDescriptor PREPROCESS_OUTPUT_DIRECTORY = new
PropertyDescriptor.Builder()
+ .name("additional-preprocesszing-output-directory")
+ .displayName("Additional Preprocessing Output Directory")
+ .description("When set, NiFi will do additional preprocessing steps
that creates modified versions of the provided ASN files," +
+ " removing unsupported features in a way that makes them less
strict but otherwise should still be compatible with incoming data." +
+ " The original files will remain intact and new ones will be
created with the same names in the provided directory." +
+ " For more information about these additional preprocessing
steps please see Additional Details - Additional Preprocessing.")
+ .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+ .addValidator(StandardValidators.createDirectoryExistsValidator(true,
false))
+ .required(false)
+ .build();
+
private final List<PropertyDescriptor> propertyDescriptors = Arrays.asList(
ROOT_MODEL_NAME,
ROOT_CLASS_NAME,
- ASN_FILES
+ ASN_FILES,
+ PREPROCESS_OUTPUT_DIRECTORY
);
private String identifier;
ComponentLog logger;
private RecordSchemaProvider schemaProvider = new RecordSchemaProvider();
+ private NiFiASNPreprocessorEngine asnPreprocessorEngine = new
NiFiASNPreprocessorEngine();
Review Comment:
Yeah, we don't even need it as field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
