tpalfy commented on code in PR #6769:
URL: https://github.com/apache/nifi/pull/6769#discussion_r1113408848
##########
nifi-nar-bundles/nifi-asn1-bundle/nifi-asn1-services/src/main/java/org/apache/nifi/jasn1/JASN1Reader.java:
##########
@@ -366,13 +387,13 @@ public void reportError(RecognitionException e) {
}
};
+ AsnModel model = new AsnModel();
+ parser.module_definitions(model);
+
if (parseError.get()) {
Review Comment:
The reportError can be - and should be - called multiple times. We want to
know as much errors as possible. Throwing the exception there would allow to
report only the first encountered issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
