lordgamez commented on code in PR #1522:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1522#discussion_r1124353151
##########
extensions/http-curl/protocols/RESTSender.cpp:
##########
@@ -181,7 +184,7 @@ C2Payload RESTSender::sendPayload(const std::string& url,
const Direction direct
const auto response_body_bytes =
gsl::make_span(client.getResponseBody()).as_span<const std::byte>();
logger_->log_trace("Received response: \"%s\"", [&] {return
utils::StringUtils::escapeUnprintableBytes(response_body_bytes);});
if (isOkay && !clientError && !serverError) {
- if (payload.isRaw()) {
+ if (accepted_formats) {
Review Comment:
So why do we check if `accepted_formats` is set here (also maybe check if it
is empty here as well)? If `accepted_formats` is not set the format is
interpreted as `*/*` on the C2 server side, which means it can return either
yaml or json, how does the processing of the response differ depending on the
`accepted_formats`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
