szaszm commented on code in PR #1522:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1522#discussion_r1124409139
##########
libminifi/src/c2/C2Agent.cpp:
##########
@@ -842,8 +842,7 @@ std::optional<std::string> C2Agent::fetchFlow(const
std::string& uri) const {
return std::nullopt;
}
- C2Payload payload(Operation::TRANSFER, true);
- C2Payload &&response =
protocol_.load()->consumePayload(resolved_url.value(), payload, RECEIVE, false);
+ C2Payload &&response = protocol_.load()->fetch(resolved_url.value(),
update_sink_->getSupportedConfigurationFormats());
Review Comment:
Would you mind removing the `&&` from here? It doesn't do anything other
than confusing readers.
```suggestion
C2Payload response = protocol_.load()->fetch(resolved_url.value(),
update_sink_->getSupportedConfigurationFormats());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
