adamdebreceni commented on code in PR #1490:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1490#discussion_r1129327118
##########
extensions/rocksdb-repos/database/OpenRocksDb.cpp:
##########
@@ -118,8 +114,15 @@ rocksdb::DB* OpenRocksDb::get() {
return impl_.get();
}
-} // namespace internal
-} // namespace minifi
-} // namespace nifi
-} // namespace apache
-} // namespace org
+std::optional<uint64_t> OpenRocksDb::getApproximateSizes() const {
+ const rocksdb::SizeApproximationOptions options{ .include_memtabtles = true
};
+ const rocksdb::Range range("", "~");
Review Comment:
could keys with leading `~` exist? content paths are prefixed with the
content dir's path, I could not find if we turn that into absolute path or not,
but if not, could the user set it relative to their home (e.g.
`~/content_repository`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
