adamdebreceni commented on code in PR #1490:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1490#discussion_r1132262862
##########
extensions/rocksdb-repos/FlowFileRepository.h:
##########
@@ -108,25 +99,17 @@ class FlowFileRepository : public ThreadedRepository,
public SwapManager {
private:
void run() override;
+ void initialize_repository();
void runCompaction();
void setCompactionPeriod(const std::shared_ptr<Configure> &configure);
- bool ExecuteWithRetry(const std::function<rocksdb::Status()>& operation);
-
- void initialize_repository();
-
- std::thread& getThread() override {
- return thread_;
- }
-
+ std::filesystem::path checkpoint_dir_;
moodycamel::ConcurrentQueue<std::string> keys_to_delete;
std::shared_ptr<core::ContentRepository> content_repo_;
- std::unique_ptr<minifi::internal::RocksDatabase> db_;
+ std::unique_ptr<rocksdb::Checkpoint> checkpoint_;
Review Comment:
was this added by accident? (and the `checkpoint_dir_` member)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
