dam4rus commented on PR #7003: URL: https://github.com/apache/nifi/pull/7003#issuecomment-1472180289
As a general rule for Python 3.x code: please use type hinting! It improves readability tremendously. Also please consider adding Python linters to the CI pipeline in the future: - mypy for typing related checks - black for formatting - flake8 for pep8 compatibility checks (sometimes doesn't play nicely with mypy and black) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
