markap14 commented on code in PR #7003:
URL: https://github.com/apache/nifi/pull/7003#discussion_r1142171807
##########
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/NiFiProperties.java:
##########
@@ -2061,6 +2074,25 @@ public Path getQuestDbStatusRepositoryPath() {
return
Paths.get(getProperty(STATUS_REPOSITORY_QUESTDB_PERSIST_LOCATION,
DEFAULT_COMPONENT_STATUS_REPOSITORY_PERSIST_LOCATION));
}
+ /**
+ * @return the directory in which the Python framework source code is
located
+ */
+ public File getPythonFrameworkSourceDirectory() {
Review Comment:
In general, that's a good approach. But I would be very hesitant to update
NiFiProperties to start using Optionals. There are hundreds of methods already,
and they generally do not use Optionals. Introducing it here would be a bad
smell - we should either use Optionals in the class or not. Mixing them would
lead to more confusion, as it would seem as if the lack of an Optional always
implied non-null return values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
