markobean commented on PR #7057:
URL: https://github.com/apache/nifi/pull/7057#issuecomment-1476519858

   > Thanks for working to correct this problem @markobean!
   > 
   > The current approach based on 
[Package.getImplementationVersion()](https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/Package.html#getImplementationVersion())
 does not seem to be inherently problematic on Java 11, but rather reflects the 
lack of package information in the JAR.
   > 
   > Did you evaluate whether the existing approach could work with updates to 
the Maven configuration so that the necessary manifest information is generated?
   
   I did not consider updating the manifest information. I made the assumption 
the missing information was inherently part of default Java 11 packaging and 
implemented an approach that would be independent of the availability of such 
information.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to