exceptionfactory commented on PR #7057:
URL: https://github.com/apache/nifi/pull/7057#issuecomment-1476906113

   Thanks for the reply @markobean.
   
   I recommend keeping the existing approach since uses standard Java package 
manifests as opposed to loading properties.
   
   There are some options for where to make the changes, but after some 
testing, adjusting the Maven JAR plugin configuration for 
`nifi-registry-data-model` seems like the best location. It did require moving 
the the `RegistryAbout` model class to a subpackage to avoid confusion with the 
standard `org.apache.nifi.registry` package, but the following commit preserves 
the same basic approach using `getPackage().getImplementationVersion()`.
   
   
https://github.com/exceptionfactory/nifi/commit/6c4386ec654eeff8e11af8b40db946cac8cd9c8f


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to