markap14 commented on PR #7003: URL: https://github.com/apache/nifi/pull/7003#issuecomment-1476969983
Thanks @dam4rus for the thorough review. As you might have guessed, I am not a Python expert. A lot of the suggestions that you make probably make a lot of sense. But they are largely not something that we want to do in this PR. Specifically, the idea of this PR is to make something available so that others who are more familiar with Python can start to iterate on it, and users can begin to experiment with the API. I aimed to make it very clear that this is not production ready through the documentation, etc. But we don't want to iterate on all the minor findings that occur before introducing this. By bringing it into the 2.0 codebase early I'm trying to get others who are more experienced in the Python side excited and iterate quickly to get to a production-ready capability. So I think most of your comments make sense but should be done in subsequent follow-on PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org