szaszm commented on code in PR #1568:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1568#discussion_r1184945575
##########
controller/tests/ControllerTests.cpp:
##########
@@ -314,14 +314,14 @@ TEST_CASE_METHOD(ControllerTestFixture, "Test
listComponents", "[controllerTests
}
using org::apache::nifi::minifi::utils::verifyEventHappenedInPollTime;
- REQUIRE(verifyEventHappenedInPollTime(500ms, [&] { return
controller_->isRunning(); }, 20ms));
+ REQUIRE(verifyEventHappenedInPollTime(5s, [&] { return
controller_->isRunning(); }, 20ms));
Review Comment:
Why are these timeouts extended 10x?
##########
cmake/DockerConfig.cmake:
##########
@@ -47,8 +47,9 @@ add_custom_target(
-DENABLE_ELASTICSEARCH=OFF
-DENABLE_LUA_SCRIPTING=OFF
-DENABLE_PYTHON_SCRIPTING=OFF
- -DENABLE_OPC=OFF
- -DENABLE_ENCRYPT_CONFIG=OFF \"
+ -DENABLE_OPC=OFF
+ -DENABLE_ENCRYPT_CONFIG=OFF
+ -DDISABLE_CONTROLLER=ON \"
Review Comment:
If the size difference is 1-2% max., then I would keep the controller inside
the container. The debugging possibilities through `docker exec` are worth a
minor overhead IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
