lordgamez commented on code in PR #1568:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1568#discussion_r1185114896
##########
cmake/DockerConfig.cmake:
##########
@@ -47,8 +47,9 @@ add_custom_target(
-DENABLE_ELASTICSEARCH=OFF
-DENABLE_LUA_SCRIPTING=OFF
-DENABLE_PYTHON_SCRIPTING=OFF
- -DENABLE_OPC=OFF
- -DENABLE_ENCRYPT_CONFIG=OFF \"
+ -DENABLE_OPC=OFF
+ -DENABLE_ENCRYPT_CONFIG=OFF
+ -DDISABLE_CONTROLLER=ON \"
Review Comment:
That makes sense, added in 765bea7fbb282048bc9c3a223f667b37620e6039
##########
controller/tests/ControllerTests.cpp:
##########
@@ -314,14 +314,14 @@ TEST_CASE_METHOD(ControllerTestFixture, "Test
listComponents", "[controllerTests
}
using org::apache::nifi::minifi::utils::verifyEventHappenedInPollTime;
- REQUIRE(verifyEventHappenedInPollTime(500ms, [&] { return
controller_->isRunning(); }, 20ms));
+ REQUIRE(verifyEventHappenedInPollTime(5s, [&] { return
controller_->isRunning(); }, 20ms));
Review Comment:
Sometimes these checks were flaky in the CI probably due to the introduced
communication of the command handlings threads through the `ConcurrentQueue`.
10 times is probably an overkill as it should probably be under 2 seconds in
the CI as well, but I wanted to make sure to remove the flakyness and only that
the functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
