tpalfy commented on code in PR #7191:
URL: https://github.com/apache/nifi/pull/7191#discussion_r1186176386
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/controller/flow/FlowManager.java:
##########
@@ -403,10 +406,50 @@ ParameterContext createParameterContext(String id, String
name, Map<String, Para
* Controller Services
* Templates
* Reporting Tasks
+ * Flow Analysis Rules
* Parameter Contexts
* Flow Registries
*
* @throws IllegalStateException if any of the components is not in a
state that it can be deleted.
*/
void purge();
+
+ // Flow Analysis
+ FlowAnalysisRuleNode createFlowAnalysisRule(
+ final String type,
+ final BundleCoordinate bundleCoordinate
+ );
+
+ FlowAnalysisRuleNode createFlowAnalysisRule(
+ final String type,
+ final BundleCoordinate bundleCoordinate,
+ final boolean firstTimeAdded
+ );
+
+ FlowAnalysisRuleNode createFlowAnalysisRule(
+ final String type,
+ final String id,
+ final BundleCoordinate bundleCoordinate,
+ final boolean firstTimeAdded
+ );
+
+ FlowAnalysisRuleNode createFlowAnalysisRule(
+ final String type,
+ final String id,
+ final BundleCoordinate bundleCoordinate,
+ final Set<URL> additionalUrls,
+ final boolean firstTimeAdded,
+ final boolean register,
+ final String classloaderIsolationKey
+ );
Review Comment:
I can remove one as it is not used. Otherwise they are justified. Processors
have 3, ReportingTasks have 4 `create` methods so this is not out of the
ordinary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
