tpalfy commented on code in PR #7191:
URL: https://github.com/apache/nifi/pull/7191#discussion_r1186236989
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/processor/StandardValidationContextFactory.java:
##########
@@ -20,25 +20,53 @@
import org.apache.nifi.components.ValidationContext;
import org.apache.nifi.controller.PropertyConfiguration;
import org.apache.nifi.controller.ValidationContextFactory;
+import org.apache.nifi.controller.flowanalysis.FlowAnalyzer;
import org.apache.nifi.controller.service.ControllerServiceProvider;
import org.apache.nifi.parameter.ParameterContext;
import org.apache.nifi.registry.VariableRegistry;
+import org.apache.nifi.validation.RuleViolationsManager;
import java.util.Map;
public class StandardValidationContextFactory implements
ValidationContextFactory {
private final ControllerServiceProvider serviceProvider;
private final VariableRegistry variableRegistry;
+ private final RuleViolationsManager ruleViolationsManager;
+ private final FlowAnalyzer flowAnalyzer;
- public StandardValidationContextFactory(final ControllerServiceProvider
serviceProvider, final VariableRegistry variableRegistry) {
+ public StandardValidationContextFactory(
+ final ControllerServiceProvider serviceProvider,
+ final VariableRegistry variableRegistry
+ ) {
+ this(serviceProvider, variableRegistry, null, null);
+ }
+
+ public StandardValidationContextFactory(
+ final ControllerServiceProvider serviceProvider,
+ final VariableRegistry variableRegistry,
+ final RuleViolationsManager ruleViolationsManager,
+ final FlowAnalyzer flowAnalyzer
Review Comment:
I think it makes sense if we don't consider the concept of Validation as
validation of the properties of a component but the validation of the component
itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
