MikeThomsen commented on code in PR #7233:
URL: https://github.com/apache/nifi/pull/7233#discussion_r1189191908
##########
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-controller-service/pom.xml:
##########
@@ -88,12 +88,6 @@
<artifactId>kudu-client</artifactId>
<version>${kudu.version}</version>
</dependency>
- <dependency>
- <groupId>org.apache.kudu</groupId>
Review Comment:
Why was this removed?
##########
nifi-commons/nifi-security-utils-api/src/test/groovy/org/apache/nifi/security/util/TlsConfigurationTest.groovy:
##########
@@ -1,90 +0,0 @@
-/*
Review Comment:
Why are you removing a bunch of unit tests without Java replacements in this
PR? Did I miss that scoped into the ticket?
##########
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-test-utils/pom.xml:
##########
@@ -65,9 +65,9 @@ language governing permissions and limitations under the
License. -->
<!-- testcontainers requires elements JUnit 4 (even when running
in JUnit 5 mode), expected to be removed in 2.x
see
https://github.com/testcontainers/testcontainers-java/issues/970
-->
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <scope>compile</scope>
+ <groupId>org.junit.vintage</groupId>
+ <artifactId>junit-vintage-engine</artifactId>
+ <scope>test</scope>
Review Comment:
IIRC, that was set as compile because it doesn't come in as a transitive
dependency when `nifi-elasticsearch-test-utils` is imported by another project.
##########
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-test-utils/pom.xml:
##########
@@ -65,9 +65,9 @@ language governing permissions and limitations under the
License. -->
<!-- testcontainers requires elements JUnit 4 (even when running
in JUnit 5 mode), expected to be removed in 2.x
see
https://github.com/testcontainers/testcontainers-java/issues/970
-->
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <scope>compile</scope>
+ <groupId>org.junit.vintage</groupId>
+ <artifactId>junit-vintage-engine</artifactId>
+ <scope>test</scope>
Review Comment:
If that happens, the tests may silently not run because there's no engine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
