exceptionfactory commented on code in PR #7233:
URL: https://github.com/apache/nifi/pull/7233#discussion_r1189212662
##########
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-test-utils/pom.xml:
##########
@@ -65,9 +65,9 @@ language governing permissions and limitations under the
License. -->
<!-- testcontainers requires elements JUnit 4 (even when running
in JUnit 5 mode), expected to be removed in 2.x
see
https://github.com/testcontainers/testcontainers-java/issues/970
-->
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <scope>compile</scope>
+ <groupId>org.junit.vintage</groupId>
+ <artifactId>junit-vintage-engine</artifactId>
+ <scope>test</scope>
Review Comment:
Good point, although if that is case, then we should add the dependency to
referencing modules, since this module does not appear to have any direction
dependencies on JUnit 4. I will look at making some adjustments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
