ChrisSamo632 commented on PR #6816: URL: https://github.com/apache/nifi/pull/6816#issuecomment-1562553195
@exceptionfactory I see a change to the `accumulo` bundle's `KeyScehama`, which extends `RecordSchema` and so needed changing to implement the updated `RecordSchema` API; and a change to a unit test for an `asn1` test case that (presumably) didn't pass without the modifications. Otherwise this PR includes the addition of the new `RemoveRecordField` processor and required changes to the associated `Record` and `RecordPath` framework classes (which obviously could impact a lot). I'm not clear on what > number changes that apply to other Processors. Although they are useful in themselves, they should be split off to separate PRs where possible can be split off from this into separate PRs As to > This new PR also includes a very large number of test files. Do you think all of those are necessary? The size and scope seem larger than needed at a glance, but I have not yet given the tests a thorough review. I agree, I was surprised there were so many test files ubt presumably these were included to try and cover the wide range of possible Record modifications that one could perform with the new processor (I largely just tried to re-invigorate #5381, I probably didn't check through every new test case/file in detail when doing so, I'll be honest) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
