ChrisSamo632 commented on PR #6816: URL: https://github.com/apache/nifi/pull/6816#issuecomment-1595856323
@exceptionfactory I've reviewed the tests and removed a few as they were overlapping enough to (I think) de-duplicate. However, there are still quite a lot being added, but I think they're justified because they cover a combination of different Schema Data Field Types (e.g. Scalar, Array, Map, Choice) along with top-level and nested fields being removed. I had a bit of a play with trying to avoid the need for both input and output schema files, but it was turning into relatively unmanageable code, e.g. to read the input schema into a JsonNode, then try to remove the fields we'd expect to not exist; so I think having all the inputs/outputs defined as files makes sense, although I've used schema inference in a couple of places to at least show that's possible too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
