szaszm opened a new pull request, #1580: URL: https://github.com/apache/nifi-minifi-cpp/pull/1580
``` Compile requests 522 Compile requests executed 522 Cache hits 499 Cache hits (C/C++) 499 Cache misses 23 Cache misses (C/C++) 23 ``` Build times before: around 1:50-2:40 hours after: 40 minutes I kept the multiple commits that show the trial/errors, they will be squashed away at merge anyway. You can check the runs of each commit by looking at the commit history of the branch on my fork. The cache/restore behavior of the sccache-action was not clear from the docs, and it didn't seem to work out of the box, so I added a separate cache action, targeting the sccache cache directory. Replaced the fiddling with PATH with a more robust solution, detecting the VS installation using `vswhere` (preinstalled on the runners), and calling the developer command line initializer batch file, making the shell effectively the same as the "x64 Native Tools Command Prompt for VS 2019". See: https://github.com/microsoft/vswhere/wiki/Find-VC Changed the build tool to ninja, because it seems to have saved about 20 minutes, and it worked without issues after changing to a VS proper developer command line. ---- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
