szaszm commented on code in PR #1580:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1580#discussion_r1206710735


##########
.github/workflows/ci.yml:
##########
@@ -88,15 +98,15 @@ jobs:
         shell: powershell
       - name: build
         run: |
-          PATH %PATH%;C:\Program Files (x86)\Windows 
Kits\10\bin\10.0.19041.0\x64
-          PATH %PATH%;C:\Program Files (x86)\Microsoft Visual 
Studio\2019\Enterprise\MSBuild\Current\Bin\Roslyn
-          win_build_vs.bat ..\b /64 /CI /S /A /PDH /SPLUNK /GCP /ELASTIC /K /L 
/R /Z /N /RO /PR /PYTHON_SCRIPTING /LUA_SCRIPTING /MQTT
+          for /f "usebackq delims=" %%i in (`vswhere.exe -latest -property 
installationPath`) do if exist "%%i\Common7\Tools\vsdevcmd.bat" call 
"%%i\Common7\Tools\vsdevcmd.bat" -arch=x64 -host_arch=x64
+          win_build_vs.bat ..\b /64 /CI /S /A /PDH /SPLUNK /GCP /ELASTIC /K /L 
/R /Z /N /RO /PR /PYTHON_SCRIPTING /LUA_SCRIPTING /MQTT /SCCACHE /NINJA
+          sccache --show-stats

Review Comment:
   While the sccache-action step sets up a post-run step that prints the same 
stats, I've added them at the end of the build, because I couldn't verify that 
after 10 minutes of idling the sccache server, when it stops, it doesn't wipe 
the stats. We may be able to remove it, but I prefer to keep it for now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to