szaszm commented on code in PR #1583:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1583#discussion_r1222987263
##########
NOTICE:
##########
Review Comment:
Could you update the copyright year near the top?
##########
bootstrap.sh:
##########
@@ -338,6 +338,9 @@ add_option PROCFS_ENABLED ${TRUE} "ENABLE_PROCFS"
add_option PROMETHEUS_ENABLED ${FALSE} "ENABLE_PROMETHEUS"
+add_option OPENSSL_ENABLED ${TRUE} "OPENSSL_OFF"
+add_dependency OPENSSL_ENABLED "opensslbuild"
Review Comment:
why call it "opensslbuild" instead of just "openssl", like the other
dependencies?
##########
cmake/GoogleCloudCpp.cmake:
##########
@@ -40,3 +40,9 @@ FetchContent_MakeAvailable(google-cloud-cpp)
if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND CMAKE_CXX_COMPILER_VERSION
VERSION_GREATER_EQUAL "14.0.0" )
target_compile_options(google_cloud_cpp_common PUBLIC
-Wno-error=deprecated-pragma)
endif()
+
+if (WIN32)
+ target_compile_options(google_cloud_cpp_storage PUBLIC /wd4996)
+else()
+ target_compile_options(google_cloud_cpp_storage PUBLIC
-Wno-error=deprecated-declarations)
Review Comment:
Would you mind adding a note with an explanation or related error messages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
