lordgamez commented on code in PR #1583:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1583#discussion_r1230573291
##########
README.md:
##########
@@ -151,6 +151,10 @@ and rebuild.
* Lua and development headers -- Required if Lua support is enabled
* libgps-dev -- Required if building libGPS support
* Zlib headers
+* perl -- Required for OpenSSL configuration
+* NASM -- Required for OpenSSL only on Windows
+
+**NOTE** On Windows if Strawberry Perl is used the
`${StrawberryPerlRoot}\c\bin` directory should not be part of the %PATH%
variable as Strawberry Perl's patch.exe will be found as the patch executable
in the configure phase instead if the git patch executable.
Review Comment:
Updated in 1a573202fd6a65332b4f7d8e8f3b6b3ecac2673a
##########
NOTICE:
##########
Review Comment:
Updated in 1a573202fd6a65332b4f7d8e8f3b6b3ecac2673a
##########
cmake/GoogleCloudCpp.cmake:
##########
@@ -40,3 +40,9 @@ FetchContent_MakeAvailable(google-cloud-cpp)
if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND CMAKE_CXX_COMPILER_VERSION
VERSION_GREATER_EQUAL "14.0.0" )
target_compile_options(google_cloud_cpp_common PUBLIC
-Wno-error=deprecated-pragma)
endif()
+
+if (WIN32)
+ target_compile_options(google_cloud_cpp_storage PUBLIC /wd4996)
+else()
+ target_compile_options(google_cloud_cpp_storage PUBLIC
-Wno-error=deprecated-declarations)
Review Comment:
Added in 1a573202fd6a65332b4f7d8e8f3b6b3ecac2673a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
