MikeThomsen commented on code in PR #7465:
URL: https://github.com/apache/nifi/pull/7465#discussion_r1257601461
##########
minifi/minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-resources/src/main/resources/conf/logback.xml:
##########
@@ -35,6 +35,8 @@
<maxFileSize>1MB</maxFileSize>
<!-- Provide a cap of 10 MB across all archive files -->
<totalSizeCap>10MB</totalSizeCap>
+ <!-- This is supposed to force log cleanup when the service
starts/restarts -->
+ <cleanHistoryOnStart>true</cleanHistoryOnStart>
Review Comment:
When I tested it locally, I set `maxHistory` to 1 so I could easily
experiment with logback's behavior. I found the cleanup was really
inconsistent, but if I set `cleanHistoryOnStart` to true it would at least be
(or seem to be) very strict at enforcing cleanup if the node got bounced. The
workflow I did was:
1. Set maxHistory to 1 (1 day)
2. Copy the current timestamped file to TS - 1 day
3. Restart node
On restart, logback cleaned up the old files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
