mosermw commented on code in PR #7465:
URL: https://github.com/apache/nifi/pull/7465#discussion_r1258812437
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/conf/logback.xml:
##########
@@ -30,10 +30,13 @@
To GZIP rolled files, replace '.log' with '.log.gz'.
To ZIP rolled files, replace '.log' with '.log.zip'.
-->
-
<fileNamePattern>${org.apache.nifi.bootstrap.config.log.dir}/nifi-app_%d{yyyy-MM-dd_HH}.%i.log</fileNamePattern>
+
<fileNamePattern>${org.apache.nifi.bootstrap.config.log.dir}/nifi-app_%d{yyyy-MM-dd_HH}.%i.log.gz</fileNamePattern>
<maxFileSize>100MB</maxFileSize>
<!-- keep 30 log files worth of history -->
<maxHistory>30</maxHistory>
+ <totalSizeCap>100GB</totalSizeCap>
Review Comment:
Actually "keep 30 log files worth of history" is a bit misleading.
maxHistory ignores the %i part of the fileNamePattern. If your pattern is
"nifi-app_%d{**yyyy-MM-dd_HH**}.%i.log" then it's maxHistory hours, and a
pattern of "nifi-app_%d{**yyyy-MM-dd**}.%i.log" is maxHistory days. You can
rollover with the %i pattern hundreds of times and maxHistory doesn't care.
Regardless, I'm in favor of a smaller default totalSizeCap instead of 100GB.
nifi-registry and stateless appear to use 10GB here. I have no idea if
totalSizeCap respects the %i pattern.
EDIT: and now I finally read the email thread from July 7-9 that says this
exact same thing. Sorry!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
