exceptionfactory commented on code in PR #7353:
URL: https://github.com/apache/nifi/pull/7353#discussion_r1261613603
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/canvas/process-group-configuration.jsp:
##########
@@ -40,6 +40,12 @@
<div class="setting-name">Process group parameter
context</div>
<div class="editable setting-field">
<div
id="process-group-parameter-context-combo"></div>
+ <div id="parameter-contexts-recursive-container">
+ <div id="parameter-contexts-recursive"
class="nf-checkbox checkbox-unchecked"></div>
+ <div class="nf-checkbox-label">Apply
recursively</div>
Review Comment:
The positioning of this checkbox seems out of place in comparison to the
other form elements. One option could be to place it directly under the
`Process Group Parameter Context` select field.
However, another complicating factor is that unlike the other settings, this
setting is not persistent. In other words, if a user checks the box and clicks
the `Apply` button, the box will be unchecked when returning to the screen.
This seems like it could create some confusion for users, especially if the UI
gives the impression that Parameter Context selection will always be applied to
any nested Process Groups.
With that background, another option could be to move this checkbox field
right above, or next to the `Apply` button. That would probably warrant
changing the labeling, because then it would appear to apply to all settings,
instead of just the Parameter Context.
Yet one more would be to introduce a new tab in the Process Group
configuration dialog specific to Parameter Contexts. That would also help
differentiate permanent settings from temporary options like this option to
apply Parameter Contexts recursively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
