timeabarna commented on code in PR #7353:
URL: https://github.com/apache/nifi/pull/7353#discussion_r1262121812
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/canvas/process-group-configuration.jsp:
##########
@@ -40,6 +40,12 @@
<div class="setting-name">Process group parameter
context</div>
<div class="editable setting-field">
<div
id="process-group-parameter-context-combo"></div>
+ <div id="parameter-contexts-recursive-container">
+ <div id="parameter-contexts-recursive"
class="nf-checkbox checkbox-unchecked"></div>
+ <div class="nf-checkbox-label">Apply
recursively</div>
Review Comment:
Thanks @exceptionfactory for your insights.
The original idea was to have a dedicated tab for Parameter Context however
after a discussion this was dropped as the current UI implementation is not
applicable for this. I think the main concern is that having Apply buttons at
two different contexts (Process Group Configuration and Parameter Context)
require some extra validations and checks which would probably introduce some
regressions.
The agreement wast to add the Apply recursive button next to the Parameter
Context selection field and as there are some more new additions to the Process
Group Configuration screen, such as Per Process Group Logging and some
stateless related configurations, have a separate PR for rearranging the screen.
The new screen planed to be similar to the Parameter Provider screen with
multiple columns where configuration fields grouped together based on some
logic which needs to be discussed as part of a different activity.
@mcgilman , @mtien-apache and @sardell please feel free to chime in and
share your thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
