szaszm commented on code in PR #1589:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1589#discussion_r1262322978
##########
libminifi/include/core/ProcessContext.h:
##########
@@ -90,6 +91,7 @@ class ProcessContext : public
controller::ControllerServiceLookup, public core::
return processor_node_;
}
+ // TODO(fgerlits): remove if possible
Review Comment:
Having TODOs is fine, but either they need fixing before merge, or the
description needs to be a bit more detailed: why consider removing these, when,
why it's not yet possible, etc.
It may be someone else who eventually gets around to doing the TODO. I'm
also fine with not having the TODO, if it doesn't add too much value, just
wanted to explain my thought process a bit better than 2 days ago. Not sure if
that's the case here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
