fgerlits commented on code in PR #1589:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1589#discussion_r1262335130
##########
libminifi/include/core/ProcessContext.h:
##########
@@ -90,6 +91,7 @@ class ProcessContext : public
controller::ControllerServiceLookup, public core::
return processor_node_;
}
+ // TODO(fgerlits): remove if possible
Review Comment:
I added these TODOs quite early on, when I still thought I could get rid of
the `Property` and `Relationship` classes completely. We might still do that
eventually, but I don't think it will be soon, and it will require changes in
many places, not just these three. So removing the TODOs is probably the best
option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
