tpalfy commented on code in PR #7191: URL: https://github.com/apache/nifi/pull/7191#discussion_r1266894080
########## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-rules/src/main/java/org/apache/nifi/flowanalysis/rules/DisallowComponentType.java: ########## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.flowanalysis.rules; + +import org.apache.nifi.annotation.documentation.CapabilityDescription; +import org.apache.nifi.annotation.documentation.Tags; +import org.apache.nifi.components.PropertyDescriptor; +import org.apache.nifi.flow.VersionedComponent; +import org.apache.nifi.flow.VersionedExtensionComponent; +import org.apache.nifi.flowanalysis.AbstractFlowAnalysisRule; +import org.apache.nifi.flowanalysis.ComponentAnalysisResult; +import org.apache.nifi.flowanalysis.FlowAnalysisRuleContext; +import org.apache.nifi.processor.util.StandardValidators; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.HashSet; +import java.util.List; + +@Tags({"component", "processor", "controller service", "type"}) +@CapabilityDescription("Produces rule violations for each component (i.e. processors or controller services) of a given type.") +public class DisallowComponentType extends AbstractFlowAnalysisRule { + public static final PropertyDescriptor COMPONENT_TYPE = new PropertyDescriptor.Builder() + .name("component-type") + .displayName("Component Type") + .description("Components of the given type will produce a rule violation (i.e. they shouldn't exist).") Review Comment: I'll update the description. UX-wise it's definitely better to be able to write the simple name which is very easy to remember or obtain. But to be able to avoid clashes it is necessary to provide an option for setting a fully qualified name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
