tpalfy commented on code in PR #7191:
URL: https://github.com/apache/nifi/pull/7191#discussion_r1286171245
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/canvas/settings-content.jsp:
##########
@@ -23,7 +23,7 @@
<div class="clear"></div>
</div>
<div id="settings-tabs-content">
- <button id="new-service-or-task" class="add-button fa fa-plus"
title="Create a new reporting task controller service" style="display:
block;"></button>
+ <button id="new-service-or-task" class="add-button fa fa-plus"
title="Create a new reporting task/flow analysis rule controller service"
style="display: block;"></button>
Review Comment:
I checked and the title of that button is overridden for each
controller-level component.
If not it's supposed to be a bug.
I think we could remove the title attribute here.
Or maybe add something that would alert us when it hasn't been overridden.
Or I can simply revert this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
