martinzink commented on code in PR #1615:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1615#discussion_r1276220914
##########
libminifi/test/unit/OsUtilTests.cpp:
##########
@@ -39,6 +39,10 @@ TEST_CASE("Test userIdToUsername for well-known SIDs",
"[OsUtils]") {
CHECK_FALSE(minifi::utils::OsUtils::userIdToUsername("S-1-3-4").empty());
CHECK_FALSE(minifi::utils::OsUtils::userIdToUsername("S-1-5-80-0").empty());
}
+#else
+TEST_CASE("OsUtilTests") {
Review Comment:
I didnt want to remove this from cmake because its reasonable that we would
add non windows tests to this file (contrary to the others because those are
inherently platform dependent). So instead I've added a test that checks if the
machine arch is supported (this may become useful for more obscure platforms we
might want to support in the future)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
