martinzink commented on code in PR #1615:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1615#discussion_r1276221155
##########
libminifi/test/unit/FileUtilsTests.cpp:
##########
@@ -186,9 +184,8 @@ TEST_CASE("TestFileUtils::addFilesMatchingExtension",
"[TestAddFilesMatchingExte
TEST_CASE("FileUtils::last_write_time and last_write_time_point work",
"[last_write_time][last_write_time_point]") {
using namespace std::chrono;
- namespace fs = std::filesystem;
- fs::file_time_type time_before_write = file_clock::now();
+ file_clock::time_point time_before_write = file_clock::now();
Review Comment:
you are absolutely right, I've fixed this in
https://github.com/apache/nifi-minifi-cpp/pull/1615/commits/44c7d79b3d130f483271f92ef7b8b224533e4137
##########
extensions/standard-processors/tests/unit/ExecuteProcessTests.cpp:
##########
@@ -170,6 +170,9 @@ TEST_CASE_METHOD(ExecuteProcessTestsFixture,
"ExecuteProcess buffer long outputs
CHECK(success_flow_files[0]->getAttribute("command") == command);
CHECK(success_flow_files[0]->getAttribute("command.arguments") == arguments);
}
-
+#else
+TEST_CASE("ExecuteProcessTests") {
+ SUCCEED("To avoid empty test executable");
+}
Review Comment:
Good idea, I've fixed it in
https://github.com/apache/nifi-minifi-cpp/pull/1615/commits/44c7d79b3d130f483271f92ef7b8b224533e4137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
