adamdebreceni commented on code in PR #1499:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1499#discussion_r1289595858
##########
libminifi/include/core/ContentRepository.h:
##########
@@ -28,20 +28,18 @@
#include "core/Connectable.h"
#include "ContentSession.h"
#include "utils/GeneralUtils.h"
+#include "core/Repository.h"
namespace org::apache::nifi::minifi::core {
/**
* Content repository definition that extends StreamManager.
*/
-class ContentRepository : public StreamManager<minifi::ResourceClaim>, public
utils::EnableSharedFromThis<ContentRepository> {
+class ContentRepository : public virtual core::Repository, public
StreamManager<minifi::ResourceClaim>, public
utils::EnableSharedFromThis<ContentRepository> {
Review Comment:
in light of changes since and future plans, rewrote this PR to not use
inheritance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
