adamdebreceni commented on code in PR #1499:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1499#discussion_r1307348649
##########
extensions/rocksdb-repos/DatabaseContentRepository.cpp:
##########
@@ -107,10 +115,15 @@ void DatabaseContentRepository::start() {
return;
}
if (compaction_period_.count() != 0) {
- compaction_thread_ = std::make_unique<utils::StoppableThread>([this] () {
+ compaction_thread_ = std::make_unique<utils::StoppableThread>([this] {
runCompaction();
});
}
+ if (purge_period_.count() != 0) {
+ gc_thread_ = std::make_unique<utils::StoppableThread>([this] {
+ runGc();
+ });
Review Comment:
as I understand, compaction and deletion could run concurrently without
blocking each other, they also operate on different time scales, merging them
could be troublesome
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
