szaszm commented on code in PR #1631:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1631#discussion_r1302035726
##########
libminifi/include/core/logging/LoggerConfiguration.h:
##########
@@ -98,15 +98,15 @@ class LoggerConfiguration {
*/
void initialize(const std::shared_ptr<LoggerProperties> &logger_properties);
- static std::unique_ptr<io::InputStream> getCompressedLog(bool flush = false)
{
- return getCompressedLog(std::chrono::milliseconds{0}, flush);
+ static std::vector<std::unique_ptr<io::InputStream>> getCompressedLogs(bool
flush = false) {
+ return getCompressedLogs(std::chrono::milliseconds{0}, flush);
Review Comment:
This new stream class that handles delegating to an inner list of streams
could handle reading from the next stream when the first one is over, and hide
the complexity inside the new class. Zlib could be involved in a lower level,
like this:
ConcatStream contains std::vector<InputStream>, where each stream is a
ZlibDecompressStream
Each ZlibDecompressStream contains the original BufferStream (or whatever)
with the compressed data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
