szaszm commented on code in PR #1631:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1631#discussion_r1302038845
##########
libminifi/src/FlowController.cpp:
##########
@@ -473,8 +473,10 @@ std::vector<BackTrace> FlowController::getTraces() {
std::map<std::string, std::unique_ptr<io::InputStream>>
FlowController::getDebugInfo() {
std::map<std::string, std::unique_ptr<io::InputStream>> debug_info;
- if (auto logs = core::logging::LoggerConfiguration::getCompressedLog(true)) {
- debug_info["minifi.log.gz"] = std::move(logs);
+ auto logs = core::logging::LoggerConfiguration::getCompressedLogs(true);
+ for (size_t i = 0; i < logs.size(); ++i) {
+ std::string index_str = i == logs.size() - 1 ? "" : "." +
std::to_string(logs.size() - 1 - i);
+ debug_info["minifi.log" + index_str + ".gz"] = std::move(logs[i]);
Review Comment:
The logs can be decompressed inside the debug archive. The tarball itself is
compressed anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
