martinzink commented on code in PR #1634:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1634#discussion_r1304328273
##########
run_clang_tidy.sh:
##########
@@ -4,7 +4,7 @@ set -uo pipefail
FILE=$1
-EXCLUDED_DIRECTORY=("extensions/pdh" "extensions/windows-event-log" "nanofi")
+EXCLUDED_DIRECTORY=("extensions/pdh" "extensions/windows-event-log"
"extensions/smb" "nanofi")
Review Comment:
I've excluded it (like the other windows only extensions), because we the CI
doesnt care if the extension is being compiled or not, and thus the
ubuntu-clang ci will try and fail to find the windows headers etc...
We could (and probably should) run the clang-tidy on windows aswell, but I
think thats probably out of the scope of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
