martinzink commented on code in PR #1634:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1634#discussion_r1304334703
##########
cmake/MiNiFiOptions.cmake:
##########
@@ -85,6 +85,7 @@ if (WIN32)
add_minifi_option(MSI_REDISTRIBUTE_UCRT_NONASL "Redistribute Universal C
Runtime DLLs with the MSI generated by CPack. The resulting MSI is not
distributable under Apache 2.0." OFF)
add_minifi_option(ENABLE_WEL "Enables the suite of Windows Event Log
extensions." OFF)
add_minifi_option(ENABLE_PDH "Enables PDH support." OFF)
+ add_minifi_option(ENABLE_SMB "Enables SMB support." ON)
Review Comment:
No particular reason, I've changed it how the other windows extensions work
in
https://github.com/apache/nifi-minifi-cpp/pull/1634/commits/b40a48a23430f4324ad31872d46077c96033def1#diff-39f29894b0102815d5fbc5a5c2d97cd04845e983c208dd90ad413c3c7e59b5b0
and enabled it in the ci in
https://github.com/apache/nifi-minifi-cpp/pull/1634/commits/4b0e1ab0ff0bcef850f74b47f7524faf48223a2d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
