lordgamez commented on code in PR #1634: URL: https://github.com/apache/nifi-minifi-cpp/pull/1634#discussion_r1305310770
########## extensions/smb/FetchSmb.cpp: ########## @@ -0,0 +1,84 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include "FetchSmb.h" +#include "core/Resource.h" +#include "utils/file/FileReaderCallback.h" + +namespace org::apache::nifi::minifi::extensions::smb { + +void FetchSmb::initialize() { + setSupportedProperties(Properties); + setSupportedRelationships(Relationships); +} + +void FetchSmb::onSchedule(const std::shared_ptr<core::ProcessContext>& context, const std::shared_ptr<core::ProcessSessionFactory>&) { + gsl_Expects(context); + if (auto connection_controller_name = context->getProperty(FetchSmb::ConnectionControllerService)) { + smb_connection_controller_service_ = std::dynamic_pointer_cast<SmbConnectionControllerService>(context->getControllerService(*connection_controller_name)); + } + if (!smb_connection_controller_service_) { + throw minifi::Exception(ExceptionType::PROCESS_SCHEDULE_EXCEPTION, "Missing SMB Connection Controller Service"); + } +} + +namespace { +std::filesystem::path getPath(core::ProcessContext& context, const std::shared_ptr<core::FlowFile>& flow_file) { + auto remote_file = context.getProperty(FetchSmb::RemoteFile, flow_file); + if (remote_file && !remote_file->empty()) { + if (remote_file->starts_with('/')) + remote_file->erase(remote_file->begin()); + return *remote_file; + } + std::filesystem::path path = flow_file->getAttribute(core::SpecialFlowAttribute::PATH).value_or(""); + std::filesystem::path filename = flow_file->getAttribute(core::SpecialFlowAttribute::FILENAME).value_or(""); + return path / filename; +} +} // namespace + +void FetchSmb::onTrigger(const std::shared_ptr<core::ProcessContext>& context, const std::shared_ptr<core::ProcessSession>& session) { + gsl_Expects(context && session && smb_connection_controller_service_); + + auto connection_error = smb_connection_controller_service_->validateConnection(); Review Comment: I think you're right, if there are intermittent connection problems or a specific drive gets mounted and unmounted time to time, then it's better to have it here. Maybe the user could have it routed into a retry processor if we had a relationship like `connection error`, but I don't want to divert from NiFi's implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
