fgerlits commented on code in PR #1634: URL: https://github.com/apache/nifi-minifi-cpp/pull/1634#discussion_r1311764737
########## extensions/smb/PutSmb.h: ########## @@ -0,0 +1,95 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#pragma once + +#include <memory> +#include <string> +#include <utility> + +#include "core/Processor.h" +#include "core/ProcessSession.h" +#include "utils/Enum.h" +#include "SmbConnectionControllerService.h" +#include "core/logging/LoggerConfiguration.h" + +namespace org::apache::nifi::minifi::extensions::smb { + +class PutSmb : public core::Processor { + public: + explicit PutSmb(std::string name, const utils::Identifier& uuid = {}) + : core::Processor(std::move(name), uuid) { + } + + ~PutSmb() override = default; + + enum class FileExistsResolutionStrategy { + fail, + replace, + ignore + }; + + EXTENSIONAPI static constexpr const char* Description = "Writes the contents of a FlowFile to an smb network location"; + + EXTENSIONAPI static constexpr auto ConnectionControllerService = core::PropertyDefinitionBuilder<>::createProperty("SMB Connection Controller Service") + .withDescription("Specifies the SMB connection controller service to use for connecting to the SMB server.") + .isRequired(true) + .withAllowedTypes<SmbConnectionControllerService>() + .build(); + EXTENSIONAPI static constexpr auto Directory = core::PropertyDefinitionBuilder<>::createProperty("Directory") + .withDescription("The output directory to which to put files") + .supportsExpressionLanguage(true) + .withDefaultValue(".") + .build(); + EXTENSIONAPI static constexpr auto ConflictResolution = core::PropertyDefinitionBuilder<3>::createProperty("Conflict Resolution Strategy") Review Comment: I think it would be better to use `magic_enum::enum_count` instead of `3`. (Also in `PutFile.h`.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
