lordgamez commented on code in PR #1638: URL: https://github.com/apache/nifi-minifi-cpp/pull/1638#discussion_r1307378898
########## LICENSE: ########## @@ -3416,3 +3416,13 @@ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. + +This product bundles 'argparse' which is available under The MIT License. Review Comment: One feature I cannot see in `cxxopts` that we used here with the `--docs` options is to provide variable number of parameters for an option. In `argparse` I could define `nargs` with 1 or 2 options depending on if the user wants to specify a second parameter for the PROCESSORS.md output. We also want to reuse the `--property` multiple times which looks to be a feature of `cxxopts` 3.0, but currently we are using 2.2. It seems that `cxxopts` is more lightweight, but with less features than `argparse` which looks to be in parity with the features of the python's argparse lib. I only saw the `ArgumentParser` class used in `EncryptConfig` so I replaced that, but I suppose it would be better to have a single argument parser in the overall codebase. What do you think, should we replace `cxxopts` in minificontroller too or can we use `cxxopts` with our options somehow? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
