szaszm commented on code in PR #1638: URL: https://github.com/apache/nifi-minifi-cpp/pull/1638#discussion_r1312114968
########## controller/CMakeLists.txt: ########## @@ -18,6 +18,9 @@ # cmake_minimum_required(VERSION 3.16) +if (CMAKE_VERSION VERSION_GREATER_EQUAL 3.24) + cmake_policy(SET CMP0135 NEW) # policy to set the timestamps of extracted contents to the time of extraction +endif() Review Comment: After #1624, we might as well change the required minimum version here as well, and get rid of the if statement. Anyone who compiles minifi will have CMake 3.24+ anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
